Go Back   EQEmulator Home > EQEmulator Forums > Development > Development::Server Code Submissions

Reply
 
Thread Tools Display Modes
  #1  
Old 04-24-2009, 11:07 AM
gatorman's Avatar
gatorman
Sarnak
 
Join Date: Jan 2008
Posts: 32
Default Fix for QuickSummoning AA (to include Call of the Hero)

The Magician AA, QuickSummoning should also affect Call of the Hero spell.

http://www.eqsummoners.com/eq1/aa-short-library.html

The following modification to the SPDat code below will allow for this to be implemented:
(note the only change was to add a check for tid == SE_SummonPC)

The only other issue with this is that the client side spell timer window does not update correctly. If anyone has any suggestions on where I can look in the code for this, I would appreciate it.

Code:
bool IsSummonSpell(int16 spellid) {
	for (int o = 0; o < EFFECT_COUNT; o++)
	{
		int32 tid = spells[spellid].effectid[o];
		if(tid == SE_SummonPet || tid == SE_SummonItem || tid == SE_SummonPC)
		{
			return true;
		}
	}
	return false;
}
-Blaz
Reply With Quote
  #2  
Old 04-30-2009, 03:28 PM
Derision
Developer
 
Join Date: Feb 2004
Location: UK
Posts: 1,540
Default

Thanks for the contribution Comitted in Rev450.

As for your question about the timer in the UI, GetActSpellCastTime is called from spells.cpp line 339, but on line 441, we send the client the unmodified cast time
Code:
begincast->cast_time = orgcasttime; // client calculates reduced time by itself
It may be that the client will only calculate the reduced cast time for focus effects, not AAs (it certainly doesn't show the reduced cast time when you right click on the spell and you have quick summoning).

If that is the case, we probably need to send the client the cast time reduced by any applicable AA effects, but not by focus items.

Last edited by Derision; 04-30-2009 at 11:53 PM..
Reply With Quote
Reply


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

   

All times are GMT -4. The time now is 05:16 AM.


 

Everquest is a registered trademark of Daybreak Game Company LLC.
EQEmulator is not associated or affiliated in any way with Daybreak Game Company LLC.
Except where otherwise noted, this site is licensed under a Creative Commons License.
       
Powered by vBulletin®, Copyright ©2000 - 2024, Jelsoft Enterprises Ltd.
Template by Bluepearl Design and vBulletin Templates - Ver3.3